fix(Tinebase): skiped passwd chrs in slow browsers

tine20 · Mar 23, 2021 · 740dbea · 740dbea
1 parent 873d90e
commit 740dbea
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 29 deletions.
diff --git a/tine20/Tinebase/css/Tinebase.less b/tine20/Tinebase/css/Tinebase.less
@@ -1038,12 +1038,6 @@ textarea.x-form-field.tinebase-editmultipledialog-noneedit {
     background-image: url(../../images/icon-set/icon_folder.svg);
 }
 
-textarea.x-form-invalid,
-.x-form-invalid {
-    background-color: #fdd;
-    border-bottom: 1px solid #ff7870 !important;
-}
-
 /*.x-form-field-wrap .x-form-search-trigger {*/
     /*background-image: url(../../images/icon-set/icon_search.svg);*/
 /*}*/

diff --git a/tine20/Tinebase/css/extjs-theme-tine20-flat.css b/tine20/Tinebase/css/extjs-theme-tine20-flat.css
@@ -920,19 +920,6 @@ textarea {
     cursor: pointer
 }
 
-.ext-webkit .x-form-invalid, .x-form-focus, textarea.x-form-focus {
-    border: 1px solid
-}
-
-.x-form-invalid, textarea.x-form-invalid {
-    background: repeat-x bottom;
-    border: 1px solid
-}
-
-.x-form-inner-invalid, textarea.x-form-inner-invalid {
-    background: repeat-x bottom
-}
-
 .x-editor {
     visibility: hidden;
     padding: 0;
@@ -4972,14 +4959,6 @@ ul.x-tab-strip-top {
     border-color: #7eadd9
 }
 
-.x-form-invalid, textarea.x-form-invalid {
-    border-color: #c30
-}
-
-.ext-webkit .x-form-invalid {
-    border-color: #ff7870
-}
-
 .x-form-grow-sizer, .x-form-item {
     font: 12px tahoma, arial, helvetica, sans-serif
 }
@@ -5455,4 +5434,4 @@ a.x-menu-item {
 
 .x-window-dlg .ext-mb-textarea {
     font: 12px tahoma, arial, helvetica, sans-serif
-}
+}
diff --git a/tine20/Tinebase/css/flat.less b/tine20/Tinebase/css/flat.less
@@ -731,6 +731,18 @@ span.x-form-twin-triggers img.x-form-clear-trigger {
   color: #000 !important;
   #transform.blacktowhite();
 }
+
+.x-form-invalid {
+  background-color: #fee !important;
+  border-bottom: 1px solid #ff7870 !important;
+}
+
+.x-form-invalid + span {
+  img.x-form-trigger {
+    background-color: #fee !important;
+    border-bottom: 1px solid #ff7870 !important;
+  }
+}
   /* GRID */
 //.cal-daysviewpanel-header-inner,
 //.cal-timelinepanel-header-label {

diff --git a/tine20/Tinebase/js/widgets/form/PasswordTriggerField.js b/tine20/Tinebase/js/widgets/form/PasswordTriggerField.js
@@ -84,6 +84,7 @@ Tine.Tinebase.widgets.form.PasswordTriggerField = Ext.extend(Ext.form.TwinTrigge
         if (e.type === 'keypress' && _.indexOf([13 /* ENTER */], e.keyCode) >= 0) return;
         Ext.lib.Event.stopEvent(e);
 
+        clearTimeout(this.selectTextTimeout);
         let start = e.target.selectionStart;
         const end = e.target.selectionEnd;
         const valueArray = (this.getValue() || '').split('');
@@ -97,7 +98,7 @@ Tine.Tinebase.widgets.form.PasswordTriggerField = Ext.extend(Ext.form.TwinTrigge
             start = start + replacement.length;
         }
         this.setValue(valueArray.join(''));
-        _.defer(() => {this.selectText(start, start)});
+        this.selectTextTimeout = setTimeout(() => {this.selectText(start, start)}, 20);
     },
 
     initTrigger: function () {
@@ -122,6 +123,7 @@ Tine.Tinebase.widgets.form.PasswordTriggerField = Ext.extend(Ext.form.TwinTrigge
             this.setRawValue(this.locked ? this.value : this.hiddenPasswordChr.repeat(this.value.length));
         }
         this.locked = !this.locked;
+        this.focus();
     },
 
     onTrigger2Click: function () {