fix(Timetracker/js): prevent factor calculation in multi edit mode

Change-Id: Ic7a4c5faba447935b5c18d50c5b8864a669f57b8
tine20 · May 19, 2021 · de9d20c · de9d20c
1 parent f51baf4
commit de9d20c
Showing 1 changed file with 21 additions and 14 deletions.
diff --git a/tine20/Timetracker/js/TimesheetEditDialog.js b/tine20/Timetracker/js/TimesheetEditDialog.js
@@ -203,25 +203,30 @@ Tine.Timetracker.TimesheetEditDialog = Ext.extend(Tine.widgets.dialog.EditDialog
     },
 
     calculateAccountingTime: function() {
-        var factor = this.getForm().findField('accounting_time_factor').getValue(),
-            duration = this.getForm().findField('duration').getValue(),
-            accountingTime = Math.round(factor * duration);
-        if (factor != this.factor) {
-            this.factor = factor;
-            this.factorChanged = true;
+        if (!this.useMultiple) {
+            var factor = this.getForm().findField('accounting_time_factor').getValue(),
+                duration = this.getForm().findField('duration').getValue(),
+                accountingTime = Math.round(factor * duration);
+            if (factor != this.factor) {
+                this.factor = factor;
+                this.factorChanged = true;
+            }
+            this.getForm().findField('accounting_time').setValue(accountingTime);
         }
-        this.getForm().findField('accounting_time').setValue(accountingTime);
     },
 
     calculateFactor: function() {
-        var duration = this.getForm().findField('duration').getValue(),
-            accountingTime = this.getForm().findField('accounting_time').getValue(),
-            factor = accountingTime / duration;
-        if (factor != this.factor) {
-            this.factor = factor;
-            this.factorChanged = true;
+        if (!this.useMultiple) {
+            var duration = this.getForm().findField('duration').getValue(),
+                accountingTime = this.getForm().findField('accounting_time').getValue(),
+                factor = accountingTime / duration;
+            if (factor != this.factor) {
+                this.factor = factor;
+                this.factorChanged = true;
+            }
+
+            this.getForm().findField('accounting_time_factor').setValue(factor);
         }
-        this.getForm().findField('accounting_time_factor').setValue(factor);
     },
 
     onCheckBillable: function(field, checked) {
@@ -414,6 +419,7 @@ Tine.Timetracker.TimesheetEditDialog = Ext.extend(Tine.widgets.dialog.EditDialog
                                             check: this.onCheckBillable
                                         }}),
                                     fieldManager('accounting_time_factor', {
+                                        disabled: this.useMultiple,
                                         columnWidth: .1,
                                         decimalSeparator: ',',
                                         fieldLabel: this.app.i18n._('Factor'),
@@ -422,6 +428,7 @@ Tine.Timetracker.TimesheetEditDialog = Ext.extend(Tine.widgets.dialog.EditDialog
                                             change: this.calculateAccountingTime
                                     }}),
                                     fieldManager('accounting_time', {
+                                        disabled: this.useMultiple,
                                         fieldLabel: this.app.i18n._('Accounting time'),
                                         listeners: {
                                             scope: this,