We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x
- [X ] bug report -> please search issues before submitting - [ ] feature request
Windows 10
5.5.0
Output from: yo --version 2.0.1 Output from: node --version, 'v9.3.0Output from:npm -v 5.6.0`
yo --version
2.0.1
node --version
Output from:
5.x.x
Start generator by typing yo and select Ngx Library
Step 3 requires no special characters
allow hyphens in github user names
The text was updated successfully, but these errors were encountered:
generator-ngx-library/app/validators.js
Line 34 in 255c6d9
should be at least this (I am not sure if github allows underscore or other special characters)
validateGithubUsername: input => { return /^[a-zA-Z0-9\-]+$/.test(input) ? true : 'Your github username cannot contain special characters or a blank space'; },
Sorry, something went wrong.
I created a pull request into your feature rollup - #145
fix(core): update github username validation to align with Github val…
e483a97
…idation rules Closes tinesoft#144
26b0e6f
No branches or pull requests
Bug Report or Feature Request (mark with an
x
)OS and Version?
Windows 10
Generator Version
5.5.0
Tools Version
Output from:
5.6.0`
yo --version
2.0.1
Output from:
node --version
,'v9.3.0
Output from:
npm -vTargeted Angular version
5.x.x
Repro steps.
Start generator by typing yo and select Ngx Library
The log given by the failure.
Step 3 requires no special characters
Desired functionality.
allow hyphens in github user names
The text was updated successfully, but these errors were encountered: