Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github usernames should allow dash/hyphen ("-") character #144

Closed
JoA-MoS opened this issue Jan 26, 2018 · 2 comments
Closed

Github usernames should allow dash/hyphen ("-") character #144

JoA-MoS opened this issue Jan 26, 2018 · 2 comments

Comments

@JoA-MoS
Copy link

JoA-MoS commented Jan 26, 2018

Bug Report or Feature Request (mark with an x)

- [X ] bug report -> please search issues before submitting
- [ ] feature request

OS and Version?

Windows 10

Generator Version

5.5.0

Tools Version

Output from: yo --version
2.0.1
Output from: node --version,
'v9.3.0Output from:npm -v 5.6.0`

Targeted Angular version

5.x.x

Repro steps.

Start generator by typing yo and select Ngx Library

The log given by the failure.

Step 3 requires no special characters

Desired functionality.

allow hyphens in github user names

@JoA-MoS
Copy link
Author

JoA-MoS commented Jan 26, 2018

return /^[a-zA-Z0-9]+$/.test(input) ? true : 'Your github username cannot contain special characters or a blank space';

should be at least this (I am not sure if github allows underscore or other special characters)

 validateGithubUsername: input => {
    return /^[a-zA-Z0-9\-]+$/.test(input) ? true : 'Your github username cannot contain special characters or a blank space';
  },

@JoA-MoS
Copy link
Author

JoA-MoS commented Jan 28, 2018

I created a pull request into your feature rollup - #145

JoA-MoS pushed a commit to JoA-MoS/generator-ngx-library that referenced this issue Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant