Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Restrictive peerDependency of rxjs causes conflicts with other packages #129

Closed
beyerleinf opened this issue Jan 14, 2023 · 0 comments
Closed

[Bug] Restrictive peerDependency of rxjs causes conflicts with other packages #129

beyerleinf opened this issue Jan 14, 2023 · 0 comments

Comments

@beyerleinf
Copy link

Ngx-CookieConsent Version

4.0.1

CookieConsent Version

3.1.1

Angular CLI (or Nx CLI) Version

15.1.1

Node Version

18.13.0

OS Version

MacOS 13.0.1

Expected Behaviour

Angular has a peerDependency of rxjs for ^7.4.0 and I'd expect this package to have the same.

Actual Behaviour

The current peerDependency of rxjs for this package is ~7.5.0 which causes conflicts with packages like ngx-bootstrap.

Steps to reproduce the behaviour

  • Use Angular 15
  • Use ngx-bootstrap@10.2.0
  • Use ngx-cookieconsent@4.0.1
  • Run npm i
  • Observe error resolving dependencies because of rxjs
NLueg added a commit to NLueg/ngx-cookieconsent that referenced this issue Feb 2, 2023
@NLueg
fix(core): make rxjs dependency less restrictive
d5f38ce 
tinesoft#129
@NLueg NLueg mentioned this issue Feb 2, 2023
Merged
tinesoft pushed a commit that referenced this issue Mar 2, 2023
@NLueg @tinesoft
fix(core): make rxjs dependency less restrictive
f74afca 
#129
github-actions bot pushed a commit that referenced this issue Mar 6, 2023
@semantic-release-bot
chore(release): 🚀 release v4.0.2
977f993 
## [4.0.2](v4.0.1...v4.0.2) (2023-03-06)

### Bug Fixes

* **core:** make `rxjs` dependency less restrictive ([66d6ebc](66d6ebc)), closes [#129](#129)

***
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@beyerleinf