[Bug] Needs to be Ivy compliant [Angular 16] #134
Comments
|
Hi have you got any update on angular 16 as 7 static forRoot(config: NgcCookieConsentConfig): ModuleWithProviders; |
|
Hoi!
For sure, I am NOT one of the library authors, sorry! If I could, I would! I am hampered with the same trouble upgrading to Angular 16. I am in the phase of stripping all View Libs out of the source. Everything needs to be Ivy compliant.
Cheers,
KWHJ
Van: bardyguillaume ***@***.***>
Verzonden: maandag 21 augustus 2023 12:17
Aan: tinesoft/ngx-cookieconsent ***@***.***>
CC: K.W.H.J. van der Kamp ***@***.***>; Author ***@***.***>
Onderwerp: Re: [tinesoft/ngx-cookieconsent] [Bug] Needs to be Ivy compliant [Angular 16] (Issue #134)
Hi have you got any update on angular 16 as
we have incompatibility
Error: node_modules/ngx-cookieconsent/cookieconsent.module.d.ts:7:53 - error NG6005: NgcCookieConsentModule.forRoot returns a ModuleWithProviders type without a generic type argument. Please add a generic type argument to the ModuleWithProviders type. If this occurrence is in library code you don't control, please contact the library authors.
7 static forRoot(config: NgcCookieConsentConfig): ModuleWithProviders;
~~~~~~~~~~~~~~~~~~~
—
Reply to this email directly, view it on GitHub <#134 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJWP72KXY4UXJ2S2KHSQA3XWMYQFANCNFSM6AAAAAAZ54WH7Q> .
You are receiving this because you authored the thread. <https://github.com/notifications/beacon/ACJWP7Y2HPYJZTAXU2QHGVLXWMYQFA5CNFSM6AAAAAAZ54WH7SWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTEP4JPU.gif> Message ID: ***@***.*** ***@***.***> >
|
|
Sorry Thanks for advice |
|
Hi guys, Thanks for using the library and sorry for the delay in responding.... |
|
Any update on this for Angular 16? Has any one found work around for this issue? |
|
Hi guys! Sorry for the delay in fixing this. I have been busy with work + other oss projects... But bear with me a bit longer, I will start updating the library to support modern angular, later this week Stay tuned! |
|
No! Unfortunately not! Actually, lost motivation to get it repaired. |
What is the alternative you are using in Angular 17? |
|
@tinesoft Any updates? |
|
...finally able to get my site up-and-running again, able to fetch data from from the firestore cloud ! With that having said, it's running without cookie-stuff, service-worker, internationalization (including left-and-right orientation). I had to remove these functionality also some other stuff based on HighCharts. I really don't no what has changed ! I was - after many trial-and-errors - able to build and deploy it to firebase, however only in the development mode. I seems to be able to build a production version however it can't be deployed due to mime errors on the script package, in the production flow need to tweek manually the index.html from the dist-folder; it's looking into the wrong sub folder, so I need to tweak manually the path to the scripts packages and surpringly if I got that fixed, it won't build a styles-package. It became really 'whipped cream' between my ears! So, overnight, I took the short corner, gambled on the fact being able to deploy the latest develop-version! So, luckily the basic side is running (not the version it should be, but)... ...oh wel! Did not have any second left to dive into reimplement cookie-stuff |
|
Hi guys, Hang tight! I've just released v5.0.0 ( fully compatible with Angular 15 + added support for standalone API). I will check for compatibility with Angular 16 and beyond, (hopefully tonight) and perform subsequent releases if needed. Until then, you can try out this new version and report here if you have issue.... |
|
Hi, thanks ! However, may bring up this... |
|
@kwhjvdkamp Looks like a configuration issue on your side (probably the provided Btw, Is your original Ivy compilation issue solved ? |
|
Hi Tine, No not solved! I decided to get rid of every IVY-related deprecated code. With that said; service-worker, internationalization and cookie stuff. Also several HighCharts aren't working anymore. I needed my base up-and-running, for now its acceptable. Need to continue with other things... |
|
Ok, thanks for the info. I will certainly release a |
BREAKING CHANGE: Angular ` v16+` is now the minimal version to use the library. Closes #134
# [6.0.0](v5.0.0...v6.0.0) (2024-01-10) ### Features * update to Angular `v16+` ([6031528](6031528)), closes [#134](#134) ### BREAKING CHANGES * Angular ` v16+` is now the minimal version to use the library. *** [skip ci]
|
🎉 This issue has been resolved in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
https://github.com/tinesoft/ngx-cookieconsent/releases/tag/v6.0.0 was released with support for Angular 16+ @kwhjvdkamp can you give it a try and let me know if everything OK ? |
Ngx-CookieConsent Version
3.1.1
CookieConsent Version
3.1.1
Angular CLI (or Nx CLI) Version
[ng version] Angular 16.1.3
Node Version
18.16.0
OS Version
Windows 11
Expected Behaviour
Working library! It seems, I misted the fact this library seems to be a non-Ivy version. Such libraries became deprecated using Angular 16.
Is there any chance, this package is going to be upgraded, becoming Ivy compliant? Please (company Osano) let the comunity know if it stays around as a non-Ivy one. People should know, thanks.
Actual Behaviour
As notified during upgrade process
Generating browser application bundles (phase: setup)...
Processing legacy 'View Engine' library:
Notification from Angular upgrade team:
Encourage the library authors to publish an Ivy distribution
Steps to reproduce the behaviour
n/a
The text was updated successfully, but these errors were encountered: