Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngx-cookieconsent@1.0.0 requires a peer of @angular/core@^2.0.0 but none is installed. You must install peer dependencies yourself. #8

Closed
acuntex opened this issue Nov 7, 2017 · 3 comments · Fixed by #58

Comments

@acuntex
Copy link

acuntex commented Nov 7, 2017

At the moment npm shows a warning when using ngx-cookieonsent with the latest angular version (5.0.0, previously 4.x).

npm WARN ngx-cookieconsent@1.0.0 requires a peer of @angular/common@^2.0.0 but none is installed. You must install peer dependencies yourself.

Any chance this can be fixed?

@tinesoft
Copy link
Owner

tinesoft commented Nov 8, 2017

Hi @acuntex

ngx-cookieconsent@1.0.0 has peerDependencies on @angular/core|common@^2.0.0, which mean any version of angular from 2.x.x to latest (installed as dependencies of your consuming app), should work just fine.

Can you show your package.json ?

@acuntex
Copy link
Author

acuntex commented Nov 9, 2017

Hi @tinesoft,
it's working perfectly but it's just an ugly warning ;-)

^2.0.0 matches 2.x.x which means that any major version bump will not match thus resulting in a warning.
You could try ">=" instead of "^" as peerdependecy.

Here is an example of another module: https://github.com/ngx-translate/core/blob/master/package.json

@tinesoft
Copy link
Owner

Hi @acuntex ,

Thanks for the tip, i have indeed misunderstood the meaning of '^' in dependency's version.
I will change that soon.

Cheers,

tinesoft added a commit that referenced this issue Jun 13, 2019
…ove typings for `NgcLawOptions`, `NgcLocationOptions`

Closes #8
tinesoft added a commit that referenced this issue Jun 14, 2019
…ove typings for `NgcLawOptions`, `NgcLocationOptions`

Closes #8
tinesoft added a commit that referenced this issue Jun 14, 2019
…ove typings for `NgcLawOptions`, `NgcLocationOptions`

Closes #8
tinesoft added a commit that referenced this issue Jun 14, 2019
…ove typings for `NgcLawOptions`, `NgcLocationOptions`

Closes #8
tinesoft added a commit that referenced this issue Jun 14, 2019
…ove typings for `NgcLawOptions`, `NgcLocationOptions`

Closes #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants