Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cookieconsent may be undefined #71

Merged
merged 1 commit into from Dec 7, 2019

Conversation

mrtnbroder
Copy link
Contributor

@mrtnbroder mrtnbroder commented Dec 6, 2019

We get errors on Sentry for older Browsers:

undefined is not an object (evaluating 'this.cookieconsent.initialise')

This is just a quickfix for it, but still better than breaking the app!

@mrtnbroder mrtnbroder force-pushed the fix-initialisation branch 2 times, most recently from 5401956 to 485b73c Compare December 6, 2019 08:47
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 87.671% when pulling a424e24 on mrtnbroder:fix-initialisation into 43717bc on tinesoft:master.

@mrtnbroder
Copy link
Contributor Author

@tinesoft can you release a hotfix? That would be awesome!

@tinesoft tinesoft merged commit 290cac3 into tinesoft:master Dec 7, 2019
@mrtnbroder
Copy link
Contributor Author

Thanks a bunch @tinesoft, can you release on npm? 😸

@mrtnbroder mrtnbroder deleted the fix-initialisation branch December 8, 2019 20:23
@tinesoft
Copy link
Owner

tinesoft commented Dec 9, 2019

Hi @mrtnbroder ,

Thanks to you for the PR. And sorry in the delay in responding.
I'll release a fix as soon as my dev environnement is up again.
( upgrading to Mac OS Catalina messed it up a lil bit... 😠 )

I'll comment back here once done.

@verbeeckjan
Copy link

@mrtnbroder is this already on npm? I have a similar error using angular 9

@github-actions
Copy link

github-actions bot commented Oct 8, 2022

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants