Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tink is not supported on Apple Silicon for iOS #6

Open
sethfri opened this issue Feb 3, 2022 · 8 comments
Open

Tink is not supported on Apple Silicon for iOS #6

sethfri opened this issue Feb 3, 2022 · 8 comments
Assignees
Labels

Comments

@sethfri
Copy link

sethfri commented Feb 3, 2022

Describe the bug:

In order for Tink to support Apple Silicon builds on iOS, it needs to be distributed as an XCFramework, Apple's new native binary format. Google will need to do the following:

  • Update the objc/BUILD file to build an xcframework
  • Host a tarball containing this xcframework
  • Publish a new version of the podspec to CocoaPods using the vendored_frameworks property to point to the xcframework

What was the expected behavior?

Importing Tink via CocoaPods should pull in an XCFramework, which allows us to build our app for device and simulator on Apple Silicon

How can we reproduce the bug?

Add pod Tink to your Podfile, run pod install, and try to build your app on Apple Silicon

Provide your version information:

  • Language: Obj-C / Swift
  • Environment: iOS
@sethfri
Copy link
Author

sethfri commented May 19, 2022

@chuckx 👋🏻 Wanted to follow up on this. This didn't land by the end of April timeline from our last discussion. Is there a new target date for Apple Silicon and XCFramework support on iOS?

@sethfri
Copy link
Author

sethfri commented May 27, 2022

Hi @chuckx, following up on this

@chuckx
Copy link
Contributor

chuckx commented May 31, 2022

FYI, I'm finalizing the XCFramework build process now. The last remaining step is integrating the symbol stripping step (since we're wrapping (Boring/Open)SSL, we need to make sure that symbols from that library aren't exposed, otherwise it can lead to symbol conflicts in projects that already include them).

This is the final blocker for releasing 1.7.0. So, as soon as I'm done, the release will be performed.

@sethfri
Copy link
Author

sethfri commented Jun 27, 2022

Hi @chuckx, are we still on track for end of June for the 1.7.0 release?

@jyothiyzen
Copy link

Hello, @chuckx any update on this. Using the latest version would be very helpful in simplifying our process a lot.

Thanks.

@oianmol
Copy link

oianmol commented Nov 14, 2022

Checking to see if there's any progress on this.

@tholenst tholenst added the p3 label Mar 20, 2023
@rickytribbia
Copy link

Hello here, any news about releasing 1.7.0 on cocoapods with M1 support?

Thanks

@mezhnik
Copy link

mezhnik commented Oct 25, 2023

Hi there,

Look forward to getting it to work on my all-new shiny M2-based MacBook :-)

Thanks

@morambro morambro transferred this issue from tink-crypto/tink Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants