Add control plane tolerations to deployments #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahreehong
force-pushed
the
add-tolerations
branch
2 times, most recently
from
90ef6ca
to
2b70f80
Compare
There was a problem hiding this comment.
Thanks, @ahreehong . As these are net new and something that a user can already add after deploying the helm chart I think we should make these opt in. Also, are there any scenarios where it would beneficial for the weight to be configurable?
jacobweinstock
force-pushed
the
add-tolerations
branch
from
2b70f80
to
d836f67
Compare
ahreehong
force-pushed
the
add-tolerations
branch
2 times, most recently
from
fba2536
to
67e563d
Compare
tinkerbell/stack/values.yaml
Outdated
| @@ -68,6 +68,11 @@ stack: | |||
| # by default macvlan is used. ipvlan is the only other option. | |||
| interfaceMode: macvlan | |||
|
|
|||
| # controlPlaneTolerations to add tolerations for deployments on control plane nodes. This is defaulted to false. | |||
| controlPlaneTolerations: | |||
There was a problem hiding this comment.
can we move this under stack:, please?
ahreehong
force-pushed
the
add-tolerations
branch
2 times, most recently
from
d30ee54
to
ed15cde
Compare
Signed-off-by: Ahree Hong <ahreeh@amazon.com>
ahreehong
force-pushed
the
add-tolerations
branch
from
ed15cde
to
3d25f18
Compare
jacobweinstock
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tolerations to all the deployments
Why is this needed
These tolerations are needed to create single node clusters successfully.
How Has This Been Tested?
Manually tested with EKS-Anywhere