Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mergify config not matching github actions jobs #137

Open
detiber opened this issue Feb 1, 2022 · 2 comments
Open

Mergify config not matching github actions jobs #137

detiber opened this issue Feb 1, 2022 · 2 comments
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@detiber
Copy link
Contributor

detiber commented Feb 1, 2022

Expected Behaviour

Mergify should merge when conditions are met, including the CI jobs defined in github actions

Current Behaviour

Mergify fails to merge the pr, showing that check-success=validate is false even when all github actions have passed.

Possible Solution

Based on https://docs.mergify.com/conditions/#about-status-checks, it looks like the configuration would be correct, in that the github actions job name is validate, however I believe it probably needs to be modified to take into account that the job is a matrix job.

Some investigation will need to be done to determine if we need to specify check-success for all combinations of the matrix job or if there is a way to configure it to check for a prefix or regex matching the matrix jobs.

@mmlb
Copy link
Contributor

mmlb commented Feb 1, 2022

Hey @detiber I just ran into something similar in tink (iirc) which PR did you have trouble with?

@mmlb
Copy link
Contributor

mmlb commented Feb 1, 2022

oh validate is a matrix type, yep we'll have to spell out each individual instance for example: tinkerbell/tink#581

@chrisdoherty4 chrisdoherty4 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 24, 2022
@chrisdoherty4 chrisdoherty4 self-assigned this Aug 29, 2022
@chrisdoherty4 chrisdoherty4 modified the milestones: v0.3, v0.4 Aug 29, 2022
@chrisdoherty4 chrisdoherty4 removed this from the v0.4 milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

3 participants