Fix remaining linter warnings and add linter GitHub action #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To resolve lll linter warnings. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
This code is mostly by convention, so there is no real need to fix it, though we may do that at some point. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Just enough to silent the golint warnings. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
We may address them at some point. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Mostly globals which are used by convention, so there is not much we can do with them unfortunately. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
This commit adds initial configuration for golangci-lint. Refs tinkerbell#7 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Right now only running linter. Closes tinkerbell#7. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
force-pushed
the
invidian/fix-remaining-linter-issues
branch
from
47bd99d
to
3d994fd
Compare
detiber
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to have automated linting to save time while reviewing the PRs, so reviews can focus on content.
Closes #7.