ENG-6658 user defined metadata #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kdeng3849, can you take a few minutes to fill out the rest of the PR template's fields? |
kqdeng
force-pushed
the
ENG-6658-user-defined-metadata
branch
from
2cbe40f
to
6362b95
Compare
This was referenced Jul 13, 2020
kqdeng
force-pushed
the
ENG-6658-user-defined-metadata
branch
from
5e632f5
to
65f01e7
Compare
kqdeng
requested review from
nathangoulding
and removed request for
nathangoulding
nathangoulding
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The metadata field under hardware is being changed to a (json formatted) string in Tink.
In order to accommodate that, this PR adds a new unmarshaller for
exportedHardwareTinkerbellto handle this change.Related PRs:
boots: tinkerbell/smee#58
tink: tinkerbell/tink#197
Why is this needed
Fixes: tinkerbell/tink#199
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Users shouldn't notice a change in how they're using the endpoints compared to before except now they will be able to see any and all fields they pushed in as metadata.
Checklist:
I have: