-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes improvements for docker compose and terraform quickstarts #174
Fixes improvements for docker compose and terraform quickstarts #174
Conversation
Signed-off-by: Douglas Wainer <douglas.g.wainer@gmail.com>
…ible with new docker-compose changes Signed-off-by: Douglas Wainer <douglas.g.wainer@gmail.com>
Signed-off-by: Douglas Wainer <douglas.g.wainer@gmail.com>
Signed-off-by: Douglas Wainer <douglas.g.wainer@gmail.com>
Signed-off-by: Douglas Wainer <douglas.g.wainer@gmail.com>
Signed-off-by: Douglas Wainer <douglas.g.wainer@gmail.com>
I've been looking into the hardware types and I can see how I could have used the
Provided the I'm happy to close this and go and rework/retest my changes and then reopen again at a later stage, if that is preferable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tremendous work, @douglaswainer, thank you!
Hey @douglaswainer, at the moment only the disks (hardware.Spec.Disks) are available for use like this. This was deliberate on our part so that we could evolve this functionality with purpose as use-cases arise. So no need to rework this. Thanks though! |
Oh interesting, I assumed the whole hardware data json could be referenced. Thank you for clarifying! |
Signed-off-by: Douglas Wainer <douglas.g.wainer@gmail.com>
@@ -0,0 +1,35 @@ | |||
# Can be set to your own hook builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not too excited about duplicate .env
files to maintain. any chance we could have only one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm not happy about it either, I can look into options for merging them into one but I don't know of an easy solution based on .env files.
There's a few bits of reused variables and bash code in the project, I was thinking of converting the bash provisioning to Ansible and splitting out the more specific provisioning tasks with roles based on whether the machine is bare metal, equinix, vagrant etc.. Though I think that would be a separate issue/PR for later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the response and especially for your work and patience on this!
Description
The primary purpose of this PR is to make the docker-compose quickstart easier to get working out of the box for people trying to run it on bare metal machines with NVME drives. It also addresses the some issues I encountered when testing these changes with the other docker-compose based quickstart guides.
Plus some cleanup to remove some code/files that I believe are legacy and no longer used.
Why is this needed
This is my attempt to address 172 and 173.
How Has This Been Tested?
I've tested by running through the quickstart documentation for all compose based quickstarts:
How are existing users impacted? What migration steps/scripts do we need?
All statements like
{{ index .Hardware.Disks 0 }}
in the deploy/stack/compose/manifests/template.yaml have been replaced with environment variables (set in the .env file) that get substituted by themanifest-update
container task. This should make it more likely to work for new users, but might confuse users that add their own manifest files.Checklist:
I have: