Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported deployment options #179

Merged
merged 16 commits into from
Nov 7, 2023
Merged

Conversation

jacobweinstock
Copy link
Member

@jacobweinstock jacobweinstock commented Oct 31, 2023

Description

In order to simplify and provide improved support we're removing all quickstart guides except for Vagrant + Virtualbox, Vagrant + Libvirt, and Kubernetes. Under the hood all guides will only be deploying the Helm chart. Once this lands we will also rename the repository. Exact name is TBD. Possibilities include: Playground, demo, example, etc.

Why is this needed

Fixes: #169
Fixes: #167
Fixes: #177
Fixes: #8
Fixes: #175

How Has This Been Tested?

Manually tested both Libvirt and Virtualbox vagrant quick starts and the Kubernetes guide.

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Latest Helm chart has nginx fixes for
virtual hardware and tftp and Hook file serving.

Remove gateway configuration because vagrant will
always provision 2 interfaces. One for vagrant management
that will provide the default gateway.

Add kexec action to template.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
New version of vagrant/virtualbox needed updating.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
shell.nix is used for dependencies in the formatting,
syntax checking.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
New quickstart guides are now in line
with the updated process.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
@jacobweinstock jacobweinstock marked this pull request as ready for review October 31, 2023 22:24
Air gapped and proxied environments are not supported.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Copy link
Member

@chrisdoherty4 chrisdoherty4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Jacob. Thanks!

@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Nov 6, 2023
@jacobweinstock
Copy link
Member Author

@Mergifyio queue

Copy link
Contributor

mergify bot commented Nov 7, 2023

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at ce44cf3

@mergify mergify bot merged commit ce44cf3 into tinkerbell:main Nov 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
2 participants