Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intelAMT): add support for HTTPS connections #224

Merged
merged 6 commits into from
May 25, 2024

Conversation

synthe102
Copy link
Contributor

@synthe102 synthe102 commented May 24, 2024

Description

This pull request add support for HTTPS connections with Intel AMT BMCs. Currently bmclib uses http as a default connection scheme which is not supported on modern AMT platforms (like the Minisforum MS-01 that I used to test this change), and there is no way to set the connection scheme to https with the current Machine API.

Why is this needed

This is needed to add support for AMT hosts that only support HTTPS connection scheme.

Fixes: #

How Has This Been Tested?

These changes were tested against a Minisforum MS-01 PC that only supports HTTPS AMT. A Machine was created that couldn't fetch the powerstate since the authentication would fail because the client would default to http. With these changes, rufio can successfully interact with the AMT BMC on the computer using https scheme.

How are existing users impacted? What migration steps/scripts do we need?

No migration is needed, the new hostScheme field defaults to http which keeps the default behavior.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

Signed-off-by: Léonard Suslian (synthe102) <leonard.suslian@gmail.com>
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 47.91%. Comparing base (736ddc0) to head (7c7a25d).

Files Patch % Lines
controller/client.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
- Coverage   47.96%   47.91%   -0.05%     
==========================================
  Files          11       11              
  Lines        1080     1081       +1     
==========================================
  Hits          518      518              
- Misses        507      508       +1     
  Partials       55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jacobweinstock jacobweinstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @synthe102 ! Just a few code comment changes.

api/v1alpha1/provider_opts.go Outdated Show resolved Hide resolved
config/crd/bases/bmc.tinkerbell.org_machines.yaml Outdated Show resolved Hide resolved
config/crd/bases/bmc.tinkerbell.org_tasks.yaml Outdated Show resolved Hide resolved
config/crd/bases/bmc.tinkerbell.org_machines.yaml Outdated Show resolved Hide resolved
config/crd/bases/bmc.tinkerbell.org_tasks.yaml Outdated Show resolved Hide resolved
@jacobweinstock jacobweinstock added the ready-to-merge Mergify: Ready for Merging label May 25, 2024
@mergify mergify bot merged commit 3f52f92 into tinkerbell:main May 25, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Mergify: Ready for Merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants