Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and document release process #107

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

detiber
Copy link
Contributor

@detiber detiber commented Oct 1, 2021

Description

Update and document release process

  • Remove old tooling around bumping container image versions and publishing binaries
  • Document the release process (push tag and github action that creates release)

Why is this needed

Previous process was undocumented and did not match up with the existing state of the repository

How are existing users impacted? What migration steps/scripts do we need?

This may affect users who were relying on binaries to be published as part of a sandbox release, but after discussing with @jacobweinstock, we are not aware of any users that are relying on the published binaries.

If it turns out that there are folks that were consuming the binaries, we can re-introduce the tooling around publishing binaries as part of the release.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)

Copy link
Member

@jacobweinstock jacobweinstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

.github/workflows/tags.yaml Outdated Show resolved Hide resolved
docs/RELEASING.md Outdated Show resolved Hide resolved
- Remove old tooling around bumping container image versions and publishing binaries
- Add script to assist with tagging a release
- Document the release process (push tag and github action that creates release)
@@ -0,0 +1,40 @@
#!/usr/bin/env bash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmlb Did quite a bit of surgery on the script you referenced, but pretty happy with how it turned out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

Copy link
Contributor

@mmlb mmlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jacobweinstock jacobweinstock merged commit ec81ce1 into tinkerbell:main Oct 4, 2021
@detiber detiber deleted the updateReleaseProcess branch October 5, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants