Upgrade to PostgreSQL 14 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Hey @rgl, looks like our DCO bot is not happy. Would you be able to maybe re-push or rebase or git ammend? |
Signed-off-by: Rui Lopes <rgl@ruilopes.com>
rgl
force-pushed
the
rgl-upgrade-to-postgres-14
branch
from
204dffe
to
bffaa7b
Compare
|
@jacobweinstock, it should be fixed now. I'm not sure what happened. |
jacobweinstock
approved these changes
Nov 2, 2021
mergify bot
added a commit
to tinkerbell/tink
that referenced
this pull request
Nov 2, 2021
## Description Upgrade to PostgreSQL 14. ## Why is this needed Besides all the major improvements made from PostgreSQL 10 to 14, there is one particular feature that I wanted to use: [A nicer way to work with JSON](https://www.postgresql.org/docs/14/datatype-json.html#JSONB-SUBSCRIPTING), like the hardware data model :-) Fixes: #551 The sandbox MR is at tinkerbell/playground#110. ## How Has This Been Tested? Besides the unit tests executed by CI, I've successfully tested this locally in a sandbox, and PostgreSQL 14 is now running: ```console root@provisioner:~# docker exec -i compose-db-1 psql -U tinkerbell -A -c 'select version()' version PostgreSQL 14.0 on x86_64-pc-linux-musl, compiled by gcc (Alpine 10.3.1_git20210424) 10.3.1 20210424, 64-bit (1 row) ``` ## How are existing users impacted? What migration steps/scripts do we need? <!--- Fixes a bug, unblocks installation, removes a component of the stack etc --> <!--- Requires a DB migration script, etc. --> ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to PostgreSQL 14.
Why is this needed
Please see tinkerbell/tink#552
Fixes: tinkerbell/tink#551