Add resource limits to the long running containers #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splaspood
previously requested changes
Nov 30, 2021
swills
force-pushed
the
compose-resource-limits
branch
from
3c0528c
to
0239f24
Compare
Prevents accidental resource exhaustion Signed-off-by: Steve Wills <steve@mouf.net>
swills
force-pushed
the
compose-resource-limits
branch
from
0239f24
to
54f6fa1
Compare
|
@splaspood Possible to stop back by for review? |
mmlb
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents accidental resource exhaustion
Signed-off-by: Steve Wills steve@mouf.net
Description
While looking at the issue in #115 I decided to add resource limits to avoid future accidental resource exhaustion. Not strictly required and perhaps the limits themselves can use tweaking, but it seems useful to add a safety.
Why is this needed
See description
Fixes: #
How Has This Been Tested?
In VM
How are existing users impacted? What migration steps/scripts do we need?
Avoids potential issue
Checklist:
I have: