backdate generated ca and server certs #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mactaggart this change lgtm but we need you to signoff on the commit as per https://github.com/tinkerbell/sandbox/blob/main/CONTRIBUTING.md#dco-sign-off can you fix that up? |
mactaggart
force-pushed
the
cfssl-backdate
branch
from
c363506
to
a9d08b3
Compare
|
@mmlb ok; fixed |
mactaggart
force-pushed
the
cfssl-backdate
branch
from
a9d08b3
to
da11c0f
Compare
mmlb
approved these changes
Apr 7, 2022
Signed-off-by: Rigo MacTaggart <rigo@skycubed.com>
displague
force-pushed
the
cfssl-backdate
branch
from
da11c0f
to
9f22118
Compare
mmlb
approved these changes
Apr 19, 2022
displague
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates cfssl configs to backdate generated certificates
Why is this needed
In some cases, a machine being provisioned may not be in time sync with the provisioner. In these cases, linuxkit is unable to download the tink-worker image from the registry because the registry's certificate is in the future. (not yet valid) Setting a backdate of anything over 24hrs will account for differences in timezone between target machine and provisioner.
Fixes: #
How Has This Been Tested?
These configuration were used to successfully provision multiple bare metal servers.
How are existing users impacted? What migration steps/scripts do we need?
This should not impact existing users or require mitigation steps.
Checklist:
I have: