Pin tink worker version to same as tink server: #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
added
kind/regression
mmlb
suggested changes
Jun 1, 2022
Comment on lines
1
to
3
| quay.io/tinkerbell/tink-worker:sha-3743d31e tinkerbell/tink-worker:latest | ||
| quay.io/tinkerbell/tink-worker:sha-3743d31e tink-worker:latest | ||
| quay.io/tinkerbell/tink-worker:sha-3743d31e tinkerbell/tink-worker:sha-5e1f0fd8 |
There was a problem hiding this comment.
Nice, thanks. Can you drop the top and bottom of these, only the tink-worker:latest is actually needed and I'd like to avoid dragging the other unused images along forever.
There was a problem hiding this comment.
NM I just applied the change myself.
mmlb
force-pushed
the
tink-worker-version-pin
branch
from
f54bdd7
to
d7121af
Compare
mmlb
approved these changes
Jun 1, 2022
This fixes an issue where the latest tink worker is not compatible with the pinned version of tink server. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com> Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
mmlb
force-pushed
the
tink-worker-version-pin
branch
from
d7121af
to
c0338b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue where the latest tink worker is not compatible with the pinned version of tink server.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: