Add support for a nat-less libvirt deployment and multiple workers #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravgahlot
approved these changes
Mar 18, 2021
gianarb
approved these changes
Mar 18, 2021
gianarb
added
the
ci-check/vagrant-setup
gianarb
suggested changes
Mar 18, 2021
There was a problem hiding this comment.
Hello! Great work this change breaks our CI/CD because it changes the name of the worker from worker to worker-1. Can you update the test suite as well? I am not sure if somewhere in the documentation is mentioned worker instead of worker-1, if so we have to update documentation as well
Updated to avoid the renaming of the first worker, the first worker will remain named |
gianarb
added
ci-check/vagrant-setup
gianarb
approved these changes
Mar 19, 2021
gianarb
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows for deploying the vagrant/libvirt setup without NAT and with multiple workers, which enables testing with cluster-api-provider-tink
Why is this needed
Helps with testing CAPT
How Has This Been Tested?
Currently testing at the moment, but all testing will consist of manual testing with vagrant/libvirt
How are existing users impacted? What migration steps/scripts do we need?
This could affect existing vagrant/libvirt users if they have an existing worker running when they update, not sure if there is a good way to avoid that, though.
Checklist:
I have: