Allow specifying an interface to bind to: #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users with multiple interfaces can limit listening to a single interface. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
added
the
kind/feature
bigzaqui
reviewed
Nov 1, 2023
| @@ -143,3 +146,59 @@ func newCLI(cfg *config, fs *flag.FlagSet) *ffcli.Command { | |||
| UsageFunc: customUsageFunc, | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Not sure why these 3 functions were added, they are not being used anywhere else in the PR
There was a problem hiding this comment.
yeah, i moved them in from another file that didn't need to exist. Sorry, it was just a clean up item!
There was a problem hiding this comment.
sounds good, pr LGTM, once merged ill work on moving from boots 0.8.0 to the latest smee version then!
bigzaqui
approved these changes
Nov 1, 2023
chrisdoherty4
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users with multiple interfaces can limit listening to a single interface.
Why is this needed
Fixes: #361
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: