Add auto discovery of trusted proxies in Kubernetes, relays and giaddr fix: #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
===================================
+ Coverage 28% 30% +2%
===================================
Files 5 5
Lines 474 526 +52
===================================
+ Hits 135 161 +26
- Misses 331 353 +22
- Partials 8 12 +4 ☔ View full report in Codecov by Sentry. |
jacobweinstock
force-pushed
the
auto-discover-trusted-proxies
branch
2 times, most recently
from
19cbd4b
to
1f09567
Compare
They will eliminate issues from users having to determine the trusted proxies. This functionality can be disabled if desired. By default we run auto discovery. This will help simplify the deployment of Smee in the Helm Chart. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
auto-discover-trusted-proxies
branch
from
4871a59
to
718859b
Compare
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
auto-discover-trusted-proxies
branch
from
db02814
to
f9bbb83
Compare
Both have fixes. dhcp has the giaddr fix. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
They will eliminate issues from users having to determine the trusted proxies. We've seen issues where the command we provided in the Helm chart doesn't accurately get the pod CIDRs from a cluster. Incorporating this into the Helm chart was tried, but ultimately not possible without extra ordinary effort and a lot of unneeded code to maintain. This functionality can be disabled if desired. By default we run auto discovery.
This will help simplify the deployment of Smee in the Helm Chart.
Also, move go.mod to Go 1.21. This is because when developing with Go 1.21 and
go mod tidywill update thego.modfile.Dependency updates for tinkerbell/dhcp provide a fix for dhcp relays and the
giaddr.Why is this needed
Fixes: #382
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: