Add proxyDHCP handler #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
added
the
do-not-merge
jacobweinstock
force-pushed
the
proxydhcp
branch
2 times, most recently
from
a6a5fb2
to
90f49d8
Compare
|
Have any idea for a timeline getting this in? Would very much like to use - would be happy to help test. |
The DHCP library was created in order to provide a mechanism for the DHCP functionality to be written in a very clean and composible way. This was not possible with the previous state of Boots and the personnel involved at that time. The current state of Smee is ready for this functionality to be return and placed in a very clean and composible way into the code base. Moving this functionality back in will improve the development process/experience. It is important to note that we do take on the trade off of not having the combined commit history of the library within Smee. The library GitHub repo will still contain history. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
This allows Smee to not have any IPAM responsibilities, especially during the network boot process. This is still a WIP and will be clean up in subsequent commits. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
The proxy and reservation handler need a good amount of the same code. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
The custom user class was not being set from the handler but from the request packet. This was not correct. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
DHCP reservation and proxy can now be toggled between via cli flag/env var. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
proxydhcp
branch
from
90f49d8
to
47efd2d
Compare
jacobweinstock
removed
the
do-not-merge
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Hey @Oogy. Should land today. |
Updated the top level readme. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
added
the
kind/feature
|
Hey @Oogy, Would you mind reporting back here how it went if/when you have some cycles to test? |
|
@jacobweinstock will do 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This add proxyDHCP support/handler. With the addition of a second handler a lot of code was moved around so that it could be used by both handlers.
With ProxyDHCP enabled Smee will respond to PXE enabled DHCP requests from clients and provide them with next boot info when netbooting. To enable this mode set
-dhcp-mode=proxy.Definition:
[A] Proxy DHCP server behaves much like a DHCP server by listening for ordinary DHCP client traffic and responding to certain client requests. However, unlike the DHCP server, the PXE Proxy DHCP server does not administer network addresses, and it only responds to clients that identify themselves as PXE clients. The responses given by the PXE Proxy DHCP server contain the mechanism by which the client locates the boot servers or the network addresses and descriptions of the supported, compatible boot servers." -- IBM
Why is this needed
Fixes: #
How Has This Been Tested?
Manually tested.
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: