Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a testsuite for migration #414

Closed
3 tasks done
gianarb opened this issue Jan 12, 2021 · 0 comments
Closed
3 tasks done

Create a testsuite for migration #414

gianarb opened this issue Jan 12, 2021 · 0 comments
Labels
triage/discuss Indicates a PR or issue that requires discussion

Comments

@gianarb
Copy link
Contributor

gianarb commented Jan 12, 2021

#383 (comment)

Screenshot 2021-01-12 at 13 50 36

Those are two reports caused by a not that defined workflow around migration. We have to improve safeguards and migration validation, even via testcontainers if needed and with static checks.

  • Write an integration test that runs all the migration and validate that they work ( this is in sandbox)
  • Write a unit test that validates that new migration have the right ID and the right function name
  • maybe we can use go generate for something here (I don't think it applies here)
@gianarb gianarb added the triage/discuss Indicates a PR or issue that requires discussion label Jan 12, 2021
@gianarb gianarb closed this as completed Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/discuss Indicates a PR or issue that requires discussion
Projects
None yet
Development

No branches or pull requests

1 participant