Simple tests for db/migration #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Mendez <mmendez@equinix.com>
This way we can add a test to do some basic validations of the migrate.Migration values. Signed-off-by: Manuel Mendez <mmendez@equinix.com>
We've had previous commits that introduced migrations where the func name and migration id did not match, that could be pretty confusing. Same thing can happen with the file name too. It just seems like a good idea to make all the timestamp/names match so we can easily go from migrations in the db to func to file. Signed-off-by: Manuel Mendez <mmendez@equinix.com>
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
==========================================
+ Coverage 33.08% 38.34% +5.25%
==========================================
Files 24 31 +7
Lines 2170 2355 +185
==========================================
+ Hits 718 903 +185
Misses 1376 1376
Partials 76 76
Continue to review full report at Codecov.
|
Just to play with coverage stats. Signed-off-by: Manuel Mendez <mmendez@equinix.com>
|
According to codecov our migrations have 100% code coverage so that means no bugs right? :D |
mmlb
changed the title
|
Thanks, I wrote this issue back then when the various bugs you referenced here showed up #414. |
gianarb
approved these changes
Jan 25, 2021
|
Yep I don't think this'll get us a fix for #414 but sets us up to work on it :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some quick/shallow test for migration definition.
Why is this needed
#371 introduced a migration where none of the names matched :D, the Id & FuncName was fixed in #383 but that one missed the file name. Why make humans do things they're bad at when instead we can make a computer do something its good at? So this is that :D.
How Has This Been Tested?
Ran
go testand it found the bad file name. I artificially changed an Id and the test caught the FuncName|Id mismatch.How are existing users impacted? What migration steps/scripts do we need?
N/A
Checklist:
I have: