-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide release binary of tink CLI #73
Comments
Ref: #74 |
No external tools like goreleaser are strictly needed. Go supports cross-compilation with a couple of flags. See the Makefile example above for instance. At a minimum the CLI should have a Linux |
There is also tinkerbell/smee#4. Perhaps one solution should be picked for all binaries. I personally like Goreleaser, as it automates building and uploading artifacts to GitHub, making GitHub releases really easy. |
In my opinion a Makefile would suffice, goreleaser is a popular, but complex tool. Bumping this up. @parauliya @gauravgahlot is there an update on this? For instance, after running the setup script, it would be ideal to be able to run "tink" without exec'ing into a container. |
We decided to release not every single project for now, but the entire stack, at the end the services are strictly connected and the project evolves quickly at this stage, it is very time-consuming to look at each project in isolation. Binaries are here: https://github.com/tinkerbell/sandbox/releases I will close this issue for now because it won't be implemented for now |
A statically-linked release binary should be made available of the tink CLI. Users shouldn't have to download go to build the CLI, or wonder where to get it from. I couldn't find docs explaining where to find it. There also are no release tags of tink, but there should be, even if the tag is 0.1.0
For an example, see how we do this with arkade or inlets
Build config for Travis/Make:
https://github.com/alexellis/arkade/blob/master/.travis.yml
https://github.com/alexellis/arkade/blob/master/Makefile
Install script:
https://github.com/alexellis/arkade/blob/master/get.sh
The text was updated successfully, but these errors were encountered: