Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide release binary of tink CLI #73

Closed
alexellis opened this issue Apr 23, 2020 · 5 comments
Closed

Provide release binary of tink CLI #73

alexellis opened this issue Apr 23, 2020 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects

Comments

@alexellis
Copy link
Contributor

A statically-linked release binary should be made available of the tink CLI. Users shouldn't have to download go to build the CLI, or wonder where to get it from. I couldn't find docs explaining where to find it. There also are no release tags of tink, but there should be, even if the tag is 0.1.0

For an example, see how we do this with arkade or inlets

Build config for Travis/Make:

https://github.com/alexellis/arkade/blob/master/.travis.yml
https://github.com/alexellis/arkade/blob/master/Makefile

Install script:

https://github.com/alexellis/arkade/blob/master/get.sh

@alexellis
Copy link
Contributor Author

Ref: #74

@alexellis
Copy link
Contributor Author

No external tools like goreleaser are strictly needed. Go supports cross-compilation with a couple of flags. See the Makefile example above for instance.

At a minimum the CLI should have a Linux x86_64 and MacOS option.

@invidian
Copy link
Contributor

There is also tinkerbell/smee#4. Perhaps one solution should be picked for all binaries.

I personally like Goreleaser, as it automates building and uploading artifacts to GitHub, making GitHub releases really easy.

@parauliya parauliya added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 30, 2020
@alexellis
Copy link
Contributor Author

In my opinion a Makefile would suffice, goreleaser is a popular, but complex tool.

Bumping this up. @parauliya @gauravgahlot is there an update on this? For instance, after running the setup script, it would be ideal to be able to run "tink" without exec'ing into a container.

@gianarb
Copy link
Contributor

gianarb commented Jan 27, 2021

We decided to release not every single project for now, but the entire stack, at the end the services are strictly connected and the project evolves quickly at this stage, it is very time-consuming to look at each project in isolation.

Binaries are here: https://github.com/tinkerbell/sandbox/releases

I will close this issue for now because it won't be implemented for now

@gianarb gianarb closed this as completed Jan 27, 2021
Issues List automation moved this from Triaged to Just shipped Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
No open projects
Issues List
  
Just shipped
Development

Successfully merging a pull request may close this issue.

5 participants