Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A task in a workflow can now have volume mounts #17

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Conversation

gauravgahlot
Copy link
Contributor

@gauravgahlot gauravgahlot commented Feb 12, 2020

The intention here is to specify all the volumes at the task level, that are common for all
actions within that task. The volumes at the task level will be mounted in all actions. However,
if a user has the same mount at the action level, it will get a higher preference and will
override the one at the task level.

Example:

version: '0.1'
name: worklfow-sample
global_timeout: 600
tasks:
- name: "task-one"
  worker: "{{index .Targets "machine1" "mac_addr"}}"
  volumes:
    - /dev:/dev
    - /dev/console:/dev/console
    - /lib/firmware:/lib/firmware
  actions:
  - name: "action-one"
    image: action-one
    timeout: 90
  - name: "action-two"
    image: action-two
    timeout: 300
    volumes:
      - /lib/firmware:/lib/firmware:ro

@gauravgahlot gauravgahlot changed the title A task in a workflow can now have volumes mounts in workfow template A task in a workflow can now have volumes mounts Feb 12, 2020
@gauravgahlot gauravgahlot changed the title A task in a workflow can now have volumes mounts A task in a workflow can now have volume mounts Feb 13, 2020
@gauravgahlot gauravgahlot self-assigned this Feb 13, 2020
@gauravgahlot gauravgahlot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 13, 2020
The intention here is to specify all the volumes at task level, that are common for all
actions within that task. The volumes at task level will be mounted in all actions. However,
if a user has the same mount at action level, it will get the higher preference and will
override the one at task level.
@parauliya parauliya merged commit c1c0b27 into workflow Mar 3, 2020
@gauravgahlot gauravgahlot deleted the task-volumes branch March 5, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants