Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #192 added PV for postgres #193

Merged
merged 3 commits into from
Jun 26, 2020

Conversation

Cbkhare
Copy link
Contributor

@Cbkhare Cbkhare commented Jun 25, 2020

Added persistent volume for postgres container in provisioner.

postgres data:

docker exec -i deploy_tink-cli_1 tink template list
+--------------------------------------+---------------+-------------------------------+-------------------------------+
| TEMPLATE ID | TEMPLATE NAME | CREATED AT | UPDATED AT |
+--------------------------------------+---------------+-------------------------------+-------------------------------+
| 2d4cfe8a-5630-481a-89ff-b34dcabad795 | hello-world | 2020-06-24 12:27:44 +0000 UTC | 2020-06-24 12:27:44 +0000 UTC |
+--------------------------------------+---------------+-------------------------------+-------------------------------+

stopping and removing of container

vagrant@provisioner:/vagrant/deploy$ docker ps
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
f5196b56e446 postgres:10-alpine "docker-entrypoint.s…" 9 minutes ago Up 9 minutes (healthy) 0.0.0.0:5432->5432/tcp deploy_db_1

vagrant@provisioner:/vagrant/deploy$ docker stop f5196b56e446
f5196b56e446
vagrant@provisioner:/vagrant/deploy$ docker rm f5196b56e446
f5196b56e446

restarting of container

vagrant@provisioner:/vagrant/deploy$ docker-compose up -d db
WARNING: The TINKERBELL_TINK_USERNAME variable is not set. Defaulting to a blank string.
WARNING: The TINKERBELL_TINK_PASSWORD variable is not set. Defaulting to a blank string.
Creating deploy_db_1 ... done

verifying data

vagrant@provisioner:/vagrant/deploy$ docker exec -i deploy_tink-cli_1 tink template list
+--------------------------------------+---------------+-------------------------------+-------------------------------+
| TEMPLATE ID | TEMPLATE NAME | CREATED AT | UPDATED AT |
+--------------------------------------+---------------+-------------------------------+-------------------------------+
| 2d4cfe8a-5630-481a-89ff-b34dcabad795 | hello-world | 2020-06-24 12:27:44 +0000 UTC | 2020-06-24 12:27:44 +0000 UTC |
+--------------------------------------+---------------+-------------------------------+-------------------------------+

@parauliya parauliya added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 25, 2020
@parauliya parauliya added this to In Progress in Issues List via automation Jun 25, 2020
@parauliya parauliya linked an issue Jun 25, 2020 that may be closed by this pull request
@Cbkhare Cbkhare changed the title 192_PV_for_postgres Fix for #192 added PV for postgres Jun 25, 2020
Copy link
Contributor

@gauravgahlot gauravgahlot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauravgahlot gauravgahlot merged commit adf2ebb into tinkerbell:master Jun 26, 2020
Issues List automation moved this from In Progress to Just shipped Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
No open projects
Issues List
  
Just shipped
Development

Successfully merging this pull request may close these issues.

Prostgres container should have a persistent volume
3 participants