Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More obvious <a> in docs #52

Closed
felixwidjaja opened this issue May 18, 2020 · 2 comments · Fixed by #61
Closed

More obvious <a> in docs #52

felixwidjaja opened this issue May 18, 2020 · 2 comments · Fixed by #61
Assignees
@ronggur
Projects
Issues List

Comments

@felixwidjaja
Copy link
Contributor

felixwidjaja commented May 18, 2020 •
edited

https://tinkerbell.org/examples/hello-world/
image

  1. @ronggur can you edit theme for <a> to be the underlined? Hover will change the color, or lose the underline.
  2. While you at it, please edit the link to https://tinkerbell.org/setup/ because the current one is 404.

*Thanks to Alex Ellis for this.
@felixwidjaja felixwidjaja changed the title Links in docs More obvious <a> in docs May 18, 2020
@mrmrcoleman mrmrcoleman added this to Requests in Issues List May 19, 2020
@ronggur ronggur mentioned this issue May 20, 2020
Merged
@ronggur
Copy link
Contributor

ronggur commented May 20, 2020

new PR ready #61

gauravgahlot pushed a commit that referenced this issue May 20, 2020
@ronggur
link highlight style #52 (#61)
19dee4d
@gauravgahlot gauravgahlot linked a pull request May 20, 2020 that will close this issue
link highlight style #52 #61
Merged
Issues List automation moved this from Requests to Just shipped May 20, 2020
parauliya pushed a commit to infracloudio/tinkerbell.org that referenced this issue May 20, 2020
@ronggur @parauliya
link highlight style tinkerbell#52 (tinkerbell#61)
bf5aec3
@felixwidjaja
Copy link
Contributor Author

I think the code was replaced, accidently. Could you please reapply @ronggur ?

@felixwidjaja felixwidjaja reopened this May 27, 2020
Issues List automation moved this from Just shipped to Requests May 27, 2020
@mrmrcoleman mrmrcoleman moved this from Requests to Just shipped in Issues List Jun 4, 2020
@ronggur ronggur closed this as completed Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ronggur ronggur

Labels
None yet
Projects
No open projects
Issues List
  
Just shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

link highlight style #52
3 participants
@ronggur @mrmrcoleman @felixwidjaja