Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content/examples: add Flatcar Container Linux provisioning page #28

Merged
merged 1 commit into from
Jul 27, 2021
Merged

content/examples: add Flatcar Container Linux provisioning page #28

merged 1 commit into from
Jul 27, 2021

Conversation

invidian
Copy link
Contributor

Replaces tinkerbell/tink#95.

Signed-off-by: Mateusz Gozdek mateusz@kinvolk.io

@invidian
Copy link
Contributor Author

I updated the example to include section about Flatcar mirror/setting up internet access for workers. It is also updated, so it no longer mentions creating target, following recent changes in Tinkerbell.

@parauliya
Copy link
Contributor

Hi @invidian , Please rebase your branch with the master so that this PR can be reviewed and merged.

@invidian
Copy link
Contributor Author

@parauliya rebased, thanks. I also looked at the wording again and improved it a bit. Please have a look.

@mrmrcoleman mrmrcoleman mentioned this pull request May 19, 2020
8 tasks
Copy link

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

content/examples/flatcar-container-linux/_index.md Outdated Show resolved Hide resolved
content/examples/flatcar-container-linux/_index.md Outdated Show resolved Hide resolved
content/examples/flatcar-container-linux/_index.md Outdated Show resolved Hide resolved
content/examples/flatcar-container-linux/_index.md Outdated Show resolved Hide resolved
content/examples/flatcar-container-linux/_index.md Outdated Show resolved Hide resolved
content/examples/flatcar-container-linux/_index.md Outdated Show resolved Hide resolved
content/examples/flatcar-container-linux/_index.md Outdated Show resolved Hide resolved
content/examples/flatcar-container-linux/_index.md Outdated Show resolved Hide resolved
content/examples/flatcar-container-linux/_index.md Outdated Show resolved Hide resolved
content/examples/flatcar-container-linux/_index.md Outdated Show resolved Hide resolved
@invidian
Copy link
Contributor Author

invidian commented Jun 4, 2020

Resolved conflicts. @parauliya could you please have a look?

command:
- sh
- -c
- echo 'eyJpZ25pdGlvbiI6eyJjb25maWciOnt9LCJzZWN1cml0eSI6eyJ0bHMiOnt9fSwidGltZW91dHMiOnt9LCJ2ZXJzaW9uIjoiMi4yLjAifSwibmV0d29ya2QiOnt9LCJwYXNzd2QiOnt9LCJzdG9yYWdlIjp7fSwic3lzdGVtZCI6e319' | base64 -d > /statedir/ignition.json
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't there a way to push this somewhere else? its really odd to have instance specific data here. shouldn't this be done when we are using workflow create instead (using e.g. {{.ignition}} here)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is not the ideal place to put it, but from my understanding of Tinkerbell architecture, this is the best place to put it. Or is is now maybe allowed to add arbitrary data while creating the workflows?

Copy link

@rgl rgl Jun 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add data when creating the workflow; like the {{.machine1}} that is in line 136.

Maybe we can also push this to the metadata service as some kind of secret?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add data when creating the workflow; like the {{.machine1}} that is in line 136.

I just tested it and indeed it seems to work, thanks! Previously, when there was still target around, this was not possible. I'll update the guide.

Maybe we can also push this to the metadata service as some kind of secret?

I don't know how this could be done. Could you elaborate your idea please?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know either. I'm still trying to understand tinkerbell. There is this thing called hengel, which has this /metadata endpoint. Can't we push data into it somehow? Is it supposed to also contain secrets?

@parauliya parauliya moved this from In Progress to Triaged in Issues List Jun 16, 2020
@invidian
Copy link
Contributor Author

invidian commented Oct 8, 2020

Would be great to get this PR merged :) Rebased on latest master.

@Raj-Dharwadkar
Copy link

@invidian Please can you rebase this PR?

Replaces tinkerbell/tink#95.

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
@invidian
Copy link
Contributor Author

@Raj-Dharwadkar rebased. I'm not sure if the content is up to date though.

Copy link
Member

@nshalman nshalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution!

Issues List automation moved this from Triaged to In Progress Jul 27, 2021
@tstromberg
Copy link
Contributor

For some reason the deploy-preview check didn't count as being run, even if I can see the results. I had to override the merge:

image

@tstromberg tstromberg merged commit 6855ba3 into tinkerbell:master Jul 27, 2021
Issues List automation moved this from In Progress to Just shipped Jul 27, 2021
@invidian invidian deleted the invidian/flatcar branch July 27, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Issues List
  
Just shipped
Development

Successfully merging this pull request may close these issues.

None yet

7 participants