Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gremlin query results toString #354

Merged
merged 1 commit into from Jun 28, 2013
Merged

Gremlin query results toString #354

merged 1 commit into from Jun 28, 2013

Conversation

pietermartin
Copy link
Contributor

From java there is a need to display the results of a query as a string.
This is already happening via the groovy console.
This pull request adds a GremlinToStringPipe that can be used in the console and from java to transform the results.

okram added a commit that referenced this pull request Jun 28, 2013
Gremlin query results toString
@okram okram merged commit e0a39cc into tinkerpop:master Jun 28, 2013
@okram
Copy link
Member

okram commented Jun 28, 2013

Thanks. This was a nice patch.

Note I called it ToStringPipe and moved it to Pipes as its generally useful to Object.toString() a stream.

Thanks again,
Marko.

http://markorodriguez.com

On Jun 12, 2013, at 12:59 PM, pietermartin notifications@github.com wrote:

From java there is a need to display the results of a query as a string.
This is already happening via the groovy console.
This pull request adds a GremlinToStringPipe that can be used in the console and from java to transform the results.

You can merge this Pull Request by running

git pull https://github.com/pietermartin/gremlin master
Or view, comment on, or merge it at:

#354

Commit Summary

Add a transform pipe to transform a query's result to a string
File Changes

M gremlin-groovy/src/main/java/com/tinkerpop/gremlin/groovy/console/ResultHookClosure.java (22)
R gremlin-java/src/main/java/com/tinkerpop/gremlin/java/ArrayIterator.java (2)
A gremlin-java/src/main/java/com/tinkerpop/gremlin/java/GremlinToStringPipe.java (47)
Patch Links:

https://github.com/tinkerpop/gremlin/pull/354.patch
https://github.com/tinkerpop/gremlin/pull/354.diff

@okram
Copy link
Member

okram commented Jun 28, 2013

Also, note the NPE bug I uncovered and fixed.

https://github.com/tinkerpop/pipes/commit/0b752c448dbd68cfd70bda8722f027f9bc26d096

On Jun 28, 2013, at 9:06 AM, Marko Rodriguez okrammarko@gmail.com wrote:

Thanks. This was a nice patch.

Note I called it ToStringPipe and moved it to Pipes as its generally useful to Object.toString() a stream.

Thanks again,
Marko.

http://markorodriguez.com

On Jun 12, 2013, at 12:59 PM, pietermartin notifications@github.com wrote:

From java there is a need to display the results of a query as a string.
This is already happening via the groovy console.
This pull request adds a GremlinToStringPipe that can be used in the console and from java to transform the results.

You can merge this Pull Request by running

git pull https://github.com/pietermartin/gremlin master
Or view, comment on, or merge it at:

#354

Commit Summary

Add a transform pipe to transform a query's result to a string
File Changes

M gremlin-groovy/src/main/java/com/tinkerpop/gremlin/groovy/console/ResultHookClosure.java (22)
R gremlin-java/src/main/java/com/tinkerpop/gremlin/java/ArrayIterator.java (2)
A gremlin-java/src/main/java/com/tinkerpop/gremlin/java/GremlinToStringPipe.java (47)
Patch Links:

https://github.com/tinkerpop/gremlin/pull/354.patch
https://github.com/tinkerpop/gremlin/pull/354.diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants