SortPipe, RangeFilterPipe and some adjustments... #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SortPipe sorts all elements. If needed sort is done only for ranged portions of all elements. RangeFilterPipe can be scoped. Several (perhaps painful) adjustments on the main classes had to be done. I hope I did not break anything. I have some testcases on some things which do work. I should do more testing with Markos testcases.
|
SortPipe is implemented by OrderPipe. No test cases provided --- can't merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SortPipe sorts all elements. If needed sort is done only for scoped
portions of all elements.
RangeFilterPipe can be scoped.
Several (perhaps painful) adjustments on the main classes had to be
done. I hope I did not break anything. I have some testcases on some
things which do work.
This is the text of my pull request of the gremlins project (I thought I should also put it here because it belongs together somehow):
Hello,
Its me again. I tried to create code for these issues I needed in my project:
XMLWriterPipe: A pipe which writes the properties of vertices it traverses onto a given XMLWriter.
SortPipe and RangeFilterPipe can be scoped.
My last pull request was a bit awkward because I did not think the thing through until the end. I hope I did it correctly this time. I have a test-case-project in which I tested what I did. But I do not know how to add this test-case to my pull-request-code because it is too big.
I had to make adjustments in the core pipes-classes. I think that is not what I would like in your position as the author of the whole stuff. But perhaps you would like to look at what I would change.
Do you want pull requests like that at all ? I'm not sure if I am a bit annoying.
Greetings
Georg