Skip to content

Fix bug with imputing nans in forecast #148

Merged
merged 3 commits into from Oct 6, 2021
Merged

Fix bug with imputing nans in forecast #148

merged 3 commits into from Oct 6, 2021

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Oct 6, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Save timestamps with nans in fit and fill only them.

Related Issue

#146.

Closing issues

Closes #146.

@Mr-Geekman Mr-Geekman self-assigned this Oct 6, 2021
@Mr-Geekman Mr-Geekman marked this pull request as ready for review October 6, 2021 15:54
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martins0n martins0n merged commit b11f399 into master Oct 6, 2021
@martins0n martins0n deleted the issue-146 branch October 6, 2021 16:25
iKintosh pushed a commit that referenced this pull request Oct 7, 2021
* Imputer transform behaviour changing

(cherry picked from commit b11f399)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Inverse transform with TimeSeriesImputerTransform
2 participants