Add VotingEnsemble #150
Merged
Add VotingEnsemble #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julia-shenshina
requested review from
iKintosh,
martins0n and
alex-hse-repository
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 87.18% 87.42% +0.23%
==========================================
Files 71 73 +2
Lines 3105 3164 +59
==========================================
+ Hits 2707 2766 +59
Misses 398 398
Continue to review full report at Codecov.
|
iKintosh
previously approved these changes
Oct 7, 2021
etna/ensembles/voting_ensemble.py
Outdated
| """Get average forecast.""" | ||
| forecast_df = forecasts[0][:, :, "target"] * self.weights[0] | ||
| for forecast, weight in zip(forecasts[1:], self.weights[1:]): | ||
| forecast_df += forecast[:, :, "target"] * weight |
There was a problem hiding this comment.
Are you sure this is a good practice?
Probably we can make this computation with only one pass
iKintosh
reviewed
Oct 7, 2021
alex-hse-repository
previously approved these changes
Oct 8, 2021
julia-shenshina
dismissed stale reviews from alex-hse-repository and iKintosh
via
6d894fc
|
👍 |
iKintosh
approved these changes
Oct 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Related Issue
Closing issues
closes #119