Skip to content

Add Correlation heatmap to EDA #77

Merged
merged 3 commits into from Sep 22, 2021
Merged

Add Correlation heatmap to EDA #77

merged 3 commits into from Sep 22, 2021

Conversation

alex-hse-repository
Copy link
Collaborator

@alex-hse-repository alex-hse-repository commented Sep 22, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (checklist)

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? make lint (poetry install -E style).
  • Did you make sure to update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you check that your code passes the unit tests pytest tests/ ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

-Add Correlation heatmap to EDA

Related Issue

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #77 (a1a97b0) into master (6c12eb6) will decrease coverage by 5.05%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   90.69%   85.64%   -5.06%     
==========================================
  Files          48       48              
  Lines        2127     2145      +18     
==========================================
- Hits         1929     1837      -92     
- Misses        198      308     +110     
Impacted Files Coverage Δ
etna/analysis/plotters.py 13.72% <16.66%> (+0.63%) ⬆️
etna/transforms/pytorch_forecasting.py 26.38% <0.00%> (-73.62%) ⬇️
etna/models/nn/tft.py 43.58% <0.00%> (-56.42%) ⬇️
etna/models/nn/deepar.py 45.94% <0.00%> (-54.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c12eb6...a1a97b0. Read the comment docs.

@julia-shenshina
Copy link
Contributor

looks 🔥

@julia-shenshina
Copy link
Contributor

add imports of new methods to etna.analysis.__init__.py please

Copy link
Contributor

@julia-shenshina julia-shenshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@julia-shenshina julia-shenshina merged commit d152d9a into master Sep 22, 2021
@iKintosh iKintosh deleted the ETNA-698 branch October 15, 2021 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants