V-optimal hist error #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
- Coverage 88.06% 87.20% -0.86%
==========================================
Files 66 67 +1
Lines 2865 3025 +160
==========================================
+ Hits 2523 2638 +115
- Misses 342 387 +45
Continue to review full report at Codecov.
|
|
how about tests? 🙂 |
|
Add docs for methods please |
julia-shenshina
previously approved these changes
Oct 5, 2021
julia-shenshina
approved these changes
Oct 6, 2021
alex-hse-repository
pushed a commit
that referenced
this pull request
Oct 7, 2021
* V-optimal hist error * First version hist anomalies * Add tests, raw version * Ready to optimize * Add docs * Add numba v1 * new tests * Minor fix * Fix bugs * Fix lint * Fix x2 * Final * Changelog * Final x2 * run workflow Co-authored-by: Andrey Alekseev <ilekseev@gmail.com>
julia-shenshina
added a commit
that referenced
this pull request
Oct 7, 2021
* Add TrendTransform * Update CHANGELOG * Fixes * Fix style * Rerun tests * Update ruptures version (#141) * Update ruptures version * Fix doccstring * Upd CHANGELOG * Fix changelog clustering typo (#137) * Add scaling for cbar in correlation_heatmap (#143) * Add scaling for cbar * Update CHANGELOG * Hist anomalies detection (#79) * V-optimal hist error * First version hist anomalies * Add tests, raw version * Ready to optimize * Add docs * Add numba v1 * new tests * Minor fix * Fix bugs * Fix lint * Fix x2 * Final * Changelog * Final x2 * run workflow Co-authored-by: Andrey Alekseev <ilekseev@gmail.com> * Fix _Binseg location * Fix style Co-authored-by: Julia Shenshina <yuliya.shenshina@phystech.edu> Co-authored-by: Mr-Geekman <36005824+Mr-Geekman@users.noreply.github.com> Co-authored-by: Artyom Makhin <48079881+Ama16@users.noreply.github.com> Co-authored-by: Andrey Alekseev <ilekseev@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (checklist)
make lint(poetry install -E style).pytest tests/?Type of Change
Proposed Changes
Related Issue
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Closing issues
Put
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).