Skip to content

Add regressor property to TSDataset #75

Closed
3 tasks done
iKintosh opened this issue Sep 21, 2021 · 0 comments · Fixed by #82
Closed
3 tasks done

Add regressor property to TSDataset #75

iKintosh opened this issue Sep 21, 2021 · 0 comments · Fixed by #82
Assignees
Labels
enhancement New feature or request

Comments

@iKintosh
Copy link
Contributor

🚀 Feature Request

Add regressor property which works similar to segment property:

https://github.com/tinkoff-ai/etna-ts/blob/6c12eb6ab66c5bd1c8d5018243e13f5e32f8bce0/etna/datasets/tsdataset.py#L219-L222

Motivation

It will eliminate need for such code checks:
https://github.com/tinkoff-ai/etna-ts/blob/6c12eb6ab66c5bd1c8d5018243e13f5e32f8bce0/etna/models/prophet.py#L113

Proposal

Add regressor property to TSDataset which returns list of all regressors in dataset

Test cases

  • Check that all regressors name are returned

Alternatives

No response

Additional context

No response

Checklist

  • Added feature request
  • Added motivation
  • Added proposal
@iKintosh iKintosh added the enhancement New feature or request label Sep 21, 2021
@Mr-Geekman Mr-Geekman self-assigned this Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants