New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pluginSubscription not called for updates to subscriptions on grp topics #757

Closed

gabriel-vasile opened this issue May 17, 2022 · 1 comment

Labels

bug

Contributor

gabriel-vasile commented May 17, 2022

chat/server/topic.go

Lines 1530 to 1535 in 48a0cfd

    
           if asChan { 
        
           	if userData.modeWant != oldWant { 
        
           		pluginSubscription(sub, plgActCreate) 
        
           	} else { 
        
           		pluginSubscription(sub, plgActUpd) 
        
           	}

Line 1534 is the only place where pluginSubscription is called with plgActUpd and it is inside if asChan

The text was updated successfully, but these errors were encountered:

or-else added a commit that referenced this issue


          notify plugins on subscription change, #757

f888679

or-else added the bug label

Contributor

or-else commented May 18, 2022

https://github.com/tinode/chat/releases/tag/v0.18.7

or-else closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment