Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Params Null in Response of {hi} - Updated #55

Merged
merged 2 commits into from
Dec 19, 2017
Merged

Fix Params Null in Response of {hi} - Updated #55

merged 2 commits into from
Dec 19, 2017

Conversation

riandyrn
Copy link
Contributor

@riandyrn riandyrn commented Dec 18, 2017 •
edited

Hello, Gene

I found glitch in {hi} response. The field "params" would be still printed even if it has zero value.

For details you could take a look at this snippet which demonstrate this issue: https://play.golang.org/p/lJiwbC8Ebg

Let me know your opinion.

Thanks

@riandyrn riandyrn changed the title Push changes update Fix Params Null in Response of {hi} - Updated Dec 18, 2017
@riandyrn riandyrn mentioned this pull request Dec 18, 2017
Closed
@or-else or-else merged commit 5b9a829 into tinode:push-changes Dec 19, 2017
@riandyrn riandyrn deleted the push-changes-update branch January 2, 2018 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@riandyrn @or-else