Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing holidays in Victoria, Australia #107

Closed
otravers opened this issue Sep 30, 2018 · 5 comments
Closed

Missing holidays in Victoria, Australia #107

otravers opened this issue Sep 30, 2018 · 5 comments
Assignees

Comments

@otravers
Copy link

Important specifications

Description

Thanks for this useful API. In the state of Victoria you're missing two sports-related public holidays: 1) Friday before the AFL Grand Final, and 2) Melbourne Cup.

The AFL holiday was introduced in 2015:
https://www.theage.com.au/national/victoria/afl-grand-final-daniel-andrews-upbeat-about-new-public-holiday-despite-interstate-threat-20150913-gjlcv9.html

Melbourne Cup has been a public holiday since 1877:

@tinohager
Copy link
Member

How i can calculate this Date AFL Grand Final -> "Day before the last Saturday in September or first Saturday in October"? https://en.wikipedia.org/wiki/Public_holidays_in_Australia

@tinohager tinohager self-assigned this Oct 1, 2018
@otravers
Copy link
Author

otravers commented Oct 1, 2018

I don't know, I'm not Australian and I don't follow their sports! It's just that I have a client there. I've googled it but didn't find anything definitive, maybe the AFL themselves could give you some insight into how it's set each year?

@tinohager
Copy link
Member

An other project have also no calculation for this day. I can only add public holidays with a formula.
https://github.com/holidays/holidays/blob/c2463483d1289c6b5a493a5de8dab0256ff4436f/lib/generated_definitions/au.rb

@Adnett10123
Copy link

@tinohager Can these two Holidays be added to the API?

@nager nager deleted a comment from Shaenn Apr 30, 2019
@tinohager
Copy link
Member

@Adnett10123 we have not found a documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants