Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect nil values for background and foreground colors #137

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

Ninjananas
Copy link
Contributor

Emacs (29.1) issues warnings when loading a theme, such as:
Warning: setting attribute ‘:background’ of face ‘header-line’: nil value is invalid, use ‘unspecified’ instead.
or
Warning: setting attribute ‘:foreground’ of face ‘message-header-cc’: nil value is invalid, use ‘unspecified’ instead.

I replaced all occurrences of nil with unspecified for :background and :foreground attributes of faces.

Everything works as expected, and the warnings are gone.

@Ninjananas Ninjananas requested a review from a team as a code owner September 11, 2023 13:35
@Ninjananas Ninjananas requested review from belak and removed request for a team September 11, 2023 13:35
@belak
Copy link
Member

belak commented Oct 5, 2023

Interesting - thanks for submitting this!

@belak belak merged commit 1c24dff into tinted-theming:main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants