-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebuild schemes #11
rebuild schemes #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's been a while since your PR (I've only become a maintainer recently). Do you still have the template file you used to generate these? I'm going to not only include newly generated colorschemes, but also update once a week so it doesn't fall out of date again. If you don't have it I can create it by working backwards from a colorscheme.
"Colour0"="95,156,146" | ||
; Base16 Apathy | ||
; schema by Jannik Siebert (https://github.com/janniks) | ||
[HKEY_CURRENT_USER\Software\SimonTatham\PuTTY\Sessions\apathy] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been a while since this commit. I was wondering why this line change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My 2 cents:
- I like the new comment 👍
- I'd personally prefer to retain the old name, I.e. retain base16 prefix.
The kitty template maybe a good starting point? |
https://github.com/abravalheri/base16-putty has a template |
@clach04 thanks for the info, it looks like this PR just generated the templates using the templates from https://github.com/abravalheri/base16-putty without acknowledging that - So I'll close this PR soon. @abravalheri what are your thoughts on merging the base16-putty repos? Or archiving this repo and bringing your repo into @base16-project as the primary base16-putty repo? If you're able to maintain it, you can stay on as the primary maintainer, but if not then we can find someone to continue maintaining the project. (tinted-theming/home#51 for some background on what base16-project is) |
Hi @JamyGolden, I am happy with any of the approaches you suggested. To be sincere with you, it is been a long time since I last messed around with base16, and I guess lots of things changed since then (e.g. I think the last builder I used was the one written in Ruby, I don't even know if the template is still compatible with the latest build specs). I am happy to help in terms of maintaining the putty templates, but I would love to share the responsibility with more people (I believe I don't have the bandwidth to be the lead maintainer). |
@abravalheri ok great. The builders we currently maintain are https://github.com/base16-project/base16-builder-go or https://github.com/base16-project/base16-builder-node. https://github.com/base16-project/base16-builder-go has a binary you can download and use to build so it doesn't require setting anything up locally. The contributing.md of one of the projects has more clear information about using the builders. I'll add you to @base16-project, you can transfer your project to the organization, I'll archive this repository and point people to the other repo and you and I can both maintain the project. I'll help set up an auto build of the colorschemes every week, like we have in the other repos (eg: tinted-theming/tinted-shell@4de166b). |
Thank you very much @JamyGolden. I tried to do the transfer (failed), but I believe we need to sort out the conflicting names of the repos first. Would you like me to change the name of the other repository, or this one? |
I tested I also updated the |
@abravalheri I've just renamed this repo. |
While this PR triggered the discussion we're having, I'm closing the PR since the discussion isn't related to this PR. |
@abravalheri what are your thoughts on bringing across your commits to this repo? This repo has a lot more stars than yours does and it would be good to preserve that. |
Hi @JamyGolden. Sorry for the delay, I just logged in, I was going to do the transfer... I don't mind any approach, really. If you prefer, we can rename the main branch and pull the commits from my repo. |
@abravalheri I've moved across the commits and kept the time of each commit. You have maintainer rights of this repo (to create PRs you can push branches directly to this repo). We can rename your repo to |
Since the content of both repos are pretty much in sync, I think I will just keep my repo as my "personal fork". Thank you very much @JamyGolden. |
built with https://github.com/obahareth/base16-builder-ruby