Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix float background #40

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Fix float background #40

merged 1 commit into from
Dec 8, 2021

Conversation

GordianDziwis
Copy link
Contributor

Description

See #38

Checklist

  • I have built the project after my changes following the build
    instructions

    using make
  • I have confirmed that my changes produce no regressions after building
  • I have pushed the built files to this pull request

@greg0ire
Copy link
Contributor

Hi! I've been using your branch locally, and I think maybe we should also use that darker background color for diffs? The light green is a bit hard to read here…

2021-11-27_14-25

@GordianDziwis
Copy link
Contributor Author

Hi! I've been using your branch locally, and I think maybe we should also use that darker background color for diffs? The light green is a bit hard to read here…

The issue is that with the darker background, the diff has the same background as the folding row, this would make the diff harder to read for all colorschemes.

@GordianDziwis GordianDziwis linked an issue Dec 1, 2021 that may be closed by this pull request
@greg0ire
Copy link
Contributor

greg0ire commented Dec 1, 2021

Then maybe the font needs to be changed to be darker when highlighted?

@GordianDziwis GordianDziwis mentioned this pull request Dec 1, 2021
3 tasks
@GordianDziwis
Copy link
Contributor Author

@greg0ire check this out #43

Copy link
Contributor

@fnune fnune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BonaBeavis I'm no longer using base16-vim. Should I give you full access to the repo? I'm hardly able to review these PRs.

@GordianDziwis
Copy link
Contributor Author

@fnune yeah, sounds reasonable. What are you using now?

@GordianDziwis GordianDziwis merged commit ebfd6a6 into master Dec 8, 2021
@GordianDziwis GordianDziwis deleted the fix-float-background branch December 8, 2021 16:44
@fnune
Copy link
Contributor

fnune commented Dec 8, 2021

Just realized you already have the maximum amount of permissions available in a user-owned (vs organization-owned) repository: Collaborator.

So feel free to merge without my approval, although I'll take a look at things when I can.

I've been trying out Falcon and Rose Pine, both of which have variants for most of the apps I use.

I'll probably come back to base16-vim one day though, especially seeing all the love it's getting 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] Background colors too light for nvim-cmp?
3 participants