Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework sslv2 handling #76

Merged
merged 1 commit into from
Oct 12, 2016
Merged

rework sslv2 handling #76

merged 1 commit into from
Oct 12, 2016

Conversation

tintinweb
Copy link
Owner

@tintinweb tintinweb added the bug label Oct 11, 2016
* fix dissector https://stackoverflow.com/questions/36622575/scapy-send-sniff-packet-with-sslv2record-not-parsed-correctly
* add sslv2 cipher RC2_CBC_128_MD5
* always perform i2m adjustment if set
* add SSLv2 unittests
@tintinweb
Copy link
Owner Author

unittests are happy; manually verified SSLv2, this is good to merge.

>>> SSL(str(SSL(records=[SSLv2Record(length=0x591, content_type=5)/"\xbf"])))
<SSL  records=[<SSLv2Record  length=0x591 content_type=5 |<Raw  load='\xbf' |>>] |>```

@alexmgr
Copy link
Collaborator

alexmgr commented Oct 12, 2016

Do you need to add RC2_CBC_128_CBC_WITH_MD5 to TLSSecurityParameters.crypto-params for future decryption to work?
Other then that, knock yourself out ;)

@tintinweb
Copy link
Owner Author

I do not think we need to put effort into adding it as it is't really widely used :)

@tintinweb tintinweb merged commit fe31e7a into master Oct 12, 2016
@tintinweb tintinweb deleted the rework/sslv2 branch November 3, 2016 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants