-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual Code Extension unable to render #138
Comments
Can you elaborate on which file this happens for you? On which platform are you trying to do this? |
this happens on any solidity contract I intend to get a graph from. I am using Windows 10. |
Can you provide a sample file? |
Yes. This contract, for instance:
returns this Digraph G file:
but does not render the graph. I can import that file to any web service providing this service and it gets rendered there. The contract I provided is just a sample. This happens with ANY contract. |
I have exactly the same problem. It creates the digraph file and pops open the preview window, but then just sits there with the "Rendering Graphviz View" popup. It was working... then it wasn't. I'm on an M1 Mac, for what that's worth. |
Hmmm, for me the digraph code renders perfectly. Are you using another extension in between? |
No |
Do you have any other tabs, text editors etc open in VS Code before trying to open this file? |
No. I just clean start VSC, load the .sol file and request the graph. I have tried it in several different ways before opening this thread and never managed to make it work. If it is due to some setup I have not been able to figure it. |
What is a .sol file? Can you provide a video of what you are doing? |
So my current guess is you are using https://github.com/ConsenSys/vscode-solidity-auditor as an extension in the middle. Using this extension I can reproduce the behaviour you are describing. (At least partly. For me the graph is rendered, but the progress notification stays open) |
I am using that extension. I do not get a partial render... just a blank canvas and open progress notification. |
For me everything works fine, when I disable the option "graphviz-interactive-preview.openAutomatically". Can you try this? |
I think I found something. It seems that in a case where the preview is loaded twice within a very short time (e.g. when another extension open a text document (where this extension automatically opens the preview) and then executes the preview command) it is possible that the render is sent to the preview panel BEFORE the settings are transmitted to the web view. This leads to the web view failing to read the settings and then crashes the web view. I will create a PR to fix this behaviour by introducing another render condition to only render the data, when the config has been transmitted to the web view. |
Should be fixed with PR #139 |
should be fixed. thanks, @bigbug 🚀 🤗 |
Whenever I try to get any graph rendered in VSC using the extension, it gets stuck "Rendering Graphviz View" as in the image shown below. The Digrapgh text files are generated properly but the are just not able to be rendered. Unable to go further.
The text was updated successfully, but these errors were encountered: