-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configmap change is not fired with "reloadOnChange: true" #78
Comments
Hi - thanks for reporting! Will take a look at this tomorrow :) |
The bug in the sample app was due to a race condition, combined with the fact that change-notification tokens are single-use (each time the notification callback is invoked, you need to request a new token and re-register your callback). #78
Turns out this is due to a combination of factors. The main problem was that change tokens are single-use; once the change callback is invoked, you have to request a new token and re-register your callback. I've updated the sample, and added logging for the config provider to improve the diagnostic experience :) Will publish a new build shortly. |
Published v0.2.12. |
Can you try out the new version and let me know if it works for you? |
Published v0.2.13. Turns out I misunderstood how config reloads are supposed to work. I have verified that the updated config is now correct. Note that, regardless of the config key case used when creating the ConfigMap, K8s transforms the config key names to lower-case for some reason (but the dictionary is case-insensitive so things still work correctly). |
Closing #82 (feel free to reopen if you still have this problem). |
in sample "ConfigFromConfigMap", change callback is never fired.
The text was updated successfully, but these errors were encountered: