Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CamelCase resolver for JSON serialization #44

Merged
merged 1 commit into from Oct 29, 2018
Merged

Use CamelCase resolver for JSON serialization #44

merged 1 commit into from Oct 29, 2018

Conversation

bastianeicher
Copy link
Contributor

This makes most of the JsonProperty attributes unnecessary. This is especially useful when serializing 3rd party DTO classes as Kubernetes Custom Resources.

This makes most of the JsonProperty attributes unnecessary. This is especially useful when serializing 3rd party DTO classes as Kubernetes Custom Resources.
@tintoy
Copy link
Owner

tintoy commented Oct 29, 2018

Thanks, good idea :)

Can't get rid of the [JsonProperty] attributes though - the K8s OpenAPI / Swagger is not all that consistent about naming unfortunately :-/

But I agree it'll definitely help for user types and as a sensible default! Will have a proper look at this once I get back to my computer.

@tintoy tintoy self-assigned this Oct 29, 2018
@tintoy tintoy added the enhancement New feature or request label Oct 29, 2018
@tintoy tintoy merged commit 07a4e13 into tintoy:develop Oct 29, 2018
@tintoy
Copy link
Owner

tintoy commented Oct 29, 2018

Thanks!

@bastianeicher bastianeicher mentioned this pull request Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants