Change K8sConfig.Locate() to follow kubectl logic #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jonstelly
commented
May 2, 2019
jonstelly
commented
- Windows AD users with Home directory mapped will have a HOME variable set
- Kubectl uses https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/util/homedir/homedir.go
- Windows AD users with Home directory mapped will have a HOME variable set - Kubectl uses https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/util/homedir/homedir.go
jonstelly
commented
May 2, 2019
|
|
||
| namespace KubeClient.Extensions.KubeConfig.Tests | ||
| { | ||
| //TODO: A better pattern here would probably be to use https://github.com/AArnott/Xunit.SkippableFact so tests for the wrong OS get marked as Inconclusive? |
There was a problem hiding this comment.
I'm not thrilled with these unit tests, but didn't want to add a new dependency on SkippableFact, wasn't sure how Inconclusive tests would be handled in CI
There was a problem hiding this comment.
From memory, it used to build on Appveyor and Travis but not sure if it still does. Probably worth revisiting :)
tintoy
approved these changes
May 2, 2019
|
Thanks! |
|
Published v0.2.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.