Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #116

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Conversation

DoctorKrolic
Copy link
Collaborator

These dependencies seem to be not used, so there is no need to include them into extension build

@tintoy i am not as much master of Node as I am of C#, so I would like your approval on this PR)

Closes #81

@tintoy
Copy link
Owner

tintoy commented Jul 30, 2023

Some of those may now be coming in as a result of indirect dependencies now.

If you're able to run vsce package (https://www.npmjs.com/package/@vscode/vsce) and don't get any compile errors then it's fine to remove them 🙂

@DoctorKrolic
Copy link
Collaborator Author

Yes, vsce package works. Not only that, but the resulted vsix size is a lot lower (2.27MB -> 241KB). + resolved dependabot alert. So this is 100% a good change

@DoctorKrolic DoctorKrolic merged commit 83efeef into master Jul 30, 2023
@DoctorKrolic DoctorKrolic deleted the dev/remove-unused-dependencies branch July 30, 2023 19:36
@tintoy
Copy link
Owner

tintoy commented Jul 30, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants